Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TerminationStatus #310

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Add TerminationStatus #310

merged 4 commits into from
Jan 6, 2023

Conversation

relf
Copy link
Contributor

@relf relf commented Jan 5, 2023 •
edited

Following the discussion here, this PR implements TerminationStatus.

API changes:

  • Added TerminationStatus
  • Removed NotTerminated variant from TerminationReason
  • Added in State trait: get_termination_status()
  • Changed in State trait: get_termination_reason() returns an Option<TerminationReason>

stefan-k
stefan-k approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for this contribution, looks like quite a bit of work!

@stefan-k stefan-k merged commit 938b3ca into argmin-rs:main Jan 6, 2023
@relf relf deleted the termination-status branch January 6, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-k stefan-k stefan-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@relf @stefan-k