Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert! macros with macros from approx crate #327

Merged
merged 3 commits into from
Jan 28, 2023
Merged

Replace assert! macros with macros from approx crate #327

merged 3 commits into from
Jan 28, 2023

Conversation

rpopplewell
Copy link
Contributor

Follows (278), changes every float equality check that gets run by cargo test -p argmin-math.

@stefan-k
Copy link
Member

Thanks a lot! :) I'll provide a review soon. I will fix the clippy lints in another PR and once that is merged you can rebase this PR. New Rust version, new clippy lints ;)

Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I only have one minor request. Once this is addressed and #328 is merged you can rebase and this is good to go!

argmin-math/src/vec/mul.rs Outdated Show resolved Hide resolved
@stefan-k
Copy link
Member

Thanks! Do you plan to make these changes also for the ndarray and nalgebra backends? You obviously don't have to, what you have done so far is already very helpful!

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Base: 93.39% // Head: 93.39% // No change to project coverage 👍

Coverage data is based on head (768523a) compared to base (a3abb7b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files         119      119           
  Lines       18975    18975           
=======================================
  Hits        17721    17721           
  Misses       1254     1254           
Impacted Files Coverage Δ
argmin-math/src/primitives/add.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/conj.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/div.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/dot.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/l1norm.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/l2norm.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/mul.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/scaledadd.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/scaledsub.rs 100.00% <100.00%> (ø)
argmin-math/src/primitives/sub.rs 100.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefan-k
Copy link
Member

Apparently everything is falling apart. I fixed the broken website build in #329.

@rpopplewell
Copy link
Contributor Author

Thanks! Do you plan to make these changes also for the ndarray and nalgebra backends? You obviously don't have to, what you have done so far is already very helpful!

Good to know I'm helpful :) Not immediately at least, but maybe in the future.

@stefan-k
Copy link
Member

LGTM. Thanks again! :)

@stefan-k stefan-k merged commit 588cbbf into argmin-rs:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants