Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the Serialize/Deserialize impls for ObserverMode #334

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

maoe
Copy link
Contributor

@maoe maoe commented Feb 20, 2023

These impls got removed in 99f16b4 perhaps by accident I suppose. We've been using these impls in our project so I'd like to restore them.

These impls got removed in 99f16b4 perhaps by accident.
@codecov-commenter
Copy link

Codecov Report

Base: 93.39% // Head: 93.38% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (85bb181) compared to base (fd8b15f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   93.39%   93.38%   -0.01%     
==========================================
  Files         119      119              
  Lines       18975    18976       +1     
==========================================
  Hits        17721    17721              
- Misses       1254     1255       +1     
Impacted Files Coverage Δ
argmin/src/core/observers/mod.rs 93.12% <0.00%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefan-k
Copy link
Member

I don't know what I was thinking when I removed this. Apologies for the inconvenience and thanks for reporting and fixing! :) I will release 0.8.1 including this fix soon-ish.

@stefan-k stefan-k merged commit d10b65d into argmin-rs:main Feb 20, 2023
@maoe
Copy link
Contributor Author

maoe commented Feb 20, 2023

Thanks for the quick turnaround!

@maoe maoe deleted the serde-observer-mode branch February 20, 2023 07:55
@stefan-k stefan-k mentioned this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants