Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix steepest descent to cache previous param #363

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

DevonMorris
Copy link
Contributor

As discussed in #362

Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix!! This looks good to me, I only have a minor request to make the CI pass.

argmin/src/solver/gradientdescent/steepestdescent.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ae98919) 93.35% compared to head (71432a6) 93.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   93.35%   93.36%           
=======================================
  Files         117      117           
  Lines       18803    18819   +16     
=======================================
+ Hits        17554    17570   +16     
  Misses       1249     1249           
Impacted Files Coverage Δ
...gmin/src/solver/gradientdescent/steepestdescent.rs 95.62% <100.00%> (+0.57%) ⬆️
argmin/src/solver/linesearch/backtracking.rs 99.05% <100.00%> (ø)
argmin/src/solver/linesearch/hagerzhang.rs 73.89% <100.00%> (ø)
argmin/src/solver/linesearch/mod.rs 77.27% <100.00%> (ø)
argmin/src/solver/linesearch/morethuente.rs 86.60% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! :)

@stefan-k stefan-k merged commit d65ce27 into argmin-rs:main Jun 21, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants