Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases for ArgminMinMax #391

Merged
merged 17 commits into from
Jan 18, 2024
Merged

Test cases for ArgminMinMax #391

merged 17 commits into from
Jan 18, 2024

Conversation

Shreyan11
Copy link
Contributor

Please do let me know if there's anything else to be done,I'm open to all suggestions.

@stefan-k stefan-k changed the title Fixed the issues from the previous pull requests Test cases for ArgminMinMax Jan 17, 2024
Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please don't open a new PR for each review, you can do all changes in one PR. There are still unnecessary changes to README.md, probably due to a failed rebase.

README.md Outdated Show resolved Hide resolved
argmin-math/src/primitives/minmax.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0be484) 90.34% compared to head (61d4bfc) 90.23%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   90.34%   90.23%   -0.11%     
==========================================
  Files         141      141              
  Lines       19869    19916      +47     
==========================================
+ Hits        17950    17972      +22     
- Misses       1919     1944      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@stefan-k stefan-k merged commit ffe5369 into argmin-rs:main Jan 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants