Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argmin_testfunctions: Edition 2021, approx crate in tests, fixed size input arrays, const generic Rosenbrock derivative and Hessian #414

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

stefan-k
Copy link
Member

@stefan-k stefan-k commented Jan 24, 2024

  • It's 2024!
  • Set edition 2021 for testfunctions crate
  • Use fixed size input arrays for test functions which work only on a fixed number of parameters. Therefore these test functions do not panic anymore.
  • Added const generic variants of the Rosenbrock derivative and Hessian. Compared to the non-const variants, those do not allocate.

@codecov-commenter
Copy link

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (a62f6aa) 90.51% compared to head (e588301) 90.39%.

Files Patch % Lines
tools/testfunctions/src/rosenbrock.rs 28.81% 42 Missing ⚠️
tools/testfunctions/src/sphere.rs 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   90.51%   90.39%   -0.12%     
==========================================
  Files         162      162              
  Lines       20373    20573     +200     
==========================================
+ Hits        18440    18597     +157     
- Misses       1933     1976      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan-k stefan-k marked this pull request as ready for review January 24, 2024 15:02
@stefan-k stefan-k changed the title argmin_testfunctions: Edition 2021, approx crate in tests argmin_testfunctions: Edition 2021, approx crate in tests, fixed size input arrays, const generic Rosenbrock derivative and Hessian Jan 24, 2024
@stefan-k stefan-k merged commit 1438820 into argmin-rs:main Jan 24, 2024
18 checks passed
@stefan-k stefan-k deleted the approx_testfunctions branch January 24, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants