Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in HCursor #188

Merged
merged 1 commit into from
Aug 11, 2015
Merged

Conversation

travisbrown
Copy link
Contributor

The important part here is first and last in HCursor—the current implementations have copy-paste errors that mean that these operations are broken on both HCursor and ACursor.

I've also corrected a couple of similar cases of copy-paste errors in history tracking, and added two missing CursorOpElement types. I've made up what I think are reasonable string representations for these, but I'm happy to change them.

I haven't added any tests, since HCursor isn't currently tested directly. I'd be happy to add something for this in a separate PR.

@seanparsons
Copy link
Member

That's a good spot, they must've been wrong for ages.

@seanparsons
Copy link
Member

Looks like a massive blind spot in our tests.

@travisbrown
Copy link
Contributor Author

@seanparsons I'm still fumbling around with testing ideas in circe, but I think abstracting over Cursor, HCursor, and ACursor is a nice way to make this specific area easier—you just write a bunch of test cases and then reuse them for each cursor type.

@seanparsons
Copy link
Member

Might just steal that.

seanparsons added a commit that referenced this pull request Aug 11, 2015
@seanparsons seanparsons merged commit c2bf2bb into argonaut-io:master Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants