Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typedoc command #11

Merged
merged 2 commits into from
Mar 15, 2016
Merged

Conversation

DNoved1
Copy link
Contributor

@DNoved1 DNoved1 commented Mar 15, 2016

Set typedoc to ignore compiler errors (since it is currently unable to process the 'readonly' attribute).

Set typedoc to ignore compiler errors (since it is currently unable to
process the 'readonly' attribute).
@speigg
Copy link
Contributor

speigg commented Mar 15, 2016

Wow does that work? It still generates documentation?

@DNoved1
Copy link
Contributor Author

DNoved1 commented Mar 15, 2016

It works for everything not marked as readonly, and for those things marked as readonly it considers it a property defined multiple times. So it generates some documentation (everything but readonly), which I figured would be better than none.

I can show you a picture of what it looks like if you'd like.

@speigg
Copy link
Contributor

speigg commented Mar 15, 2016

AWESOME. Just tried it. Let's just remove our readonly modifiers.

@speigg
Copy link
Contributor

speigg commented Mar 15, 2016

Go ahead and make that change and I'll merge this PR

@DNoved1
Copy link
Contributor Author

DNoved1 commented Mar 15, 2016

You want me to remove all the readonly modifiers?

Temporary measure until typedoc is updated to properly support them.
@speigg
Copy link
Contributor

speigg commented Mar 15, 2016

Yeah, it won't break anything. It just means people won't get errors if they try to write to those properties (which is not ideal, but we can use a more verbose pattern of get accessor + private internal property in order to provide run-time safety and still generate working documentation). Hopefully typedoc will get updated soon though...

@speigg
Copy link
Contributor

speigg commented Mar 15, 2016

Just remove the modifiers for now though.

speigg added a commit that referenced this pull request Mar 15, 2016
Update typedoc command and remove readonly modifiers
@speigg speigg merged commit 68740ef into argonjs:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants