Add a logic for RolloutManager to create ServiceMonitor #49
+762
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rizwana777
force-pushed
the
issue-3924
branch
26 times, most recently
from
54fb2a7
to
0822a10
Compare
jgwest
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Thanks @Rizwana777! I have also verified that the Rollouts metrics are available from the OpenShift console UI, after a RolloutManager CR is created.
Rizwana777
force-pushed
the
issue-3924
branch
3 times, most recently
from
111dece
to
4263dbd
Compare
Rizwana777
force-pushed
the
issue-3924
branch
2 times, most recently
from
6767d29
to
1dbd358
Compare
Rizwana777
force-pushed
the
issue-3924
branch
2 times, most recently
from
3d5917e
to
a2c611d
Compare
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Rizwana777
force-pushed
the
issue-3924
branch
7 times, most recently
from
4f73244
to
31ccc21
Compare
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
jgwest
requested changes
May 15, 2024
Rizwana777
force-pushed
the
issue-3924
branch
3 times, most recently
from
6d1ac70
to
fdfa81c
Compare
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #29
Added logic for RolloutManager to create ServiceMonitor and Added unit test and e2e test