Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Back to kustomization.yml #199

Closed
iamnoah opened this issue Apr 28, 2021 · 0 comments · Fixed by #200
Closed

Write Back to kustomization.yml #199

iamnoah opened this issue Apr 28, 2021 · 0 comments · Fixed by #200
Labels
enhancement New feature or request

Comments

@iamnoah
Copy link
Contributor

iamnoah commented Apr 28, 2021

Is your feature request related to a problem? Please describe.

I like my overrides checked in to git. While .argocd-source.yml is nice, in practice, I find that I want to use the overriden images for other purposes too, e.g., setting up a local Minikube environment. It sucks that I can't get updated images when using the same base with local kustomize. The end result is that my local environment has to be manually and painstakingly updated while my dev environment is always up to date.

Describe the solution you'd like

Update kustomization.yml instead. Can be done easily with kustomize edit set image. I think it would just look like one more write back method, and be implemented as such.

Describe alternatives you've considered

Other options I considered:

  • Run a script in my CI that parses the file and runs the right kustomize edit set image commands. That's yet another commit, and increases the odds of causing some kind of weird CI+CD feedback loop.
  • A kustomize plugin - painful for end users to consume.

I'll probably do this myself in the next few days and submit a PR, but thought I should put this in to see if anyone else has thoughts on it.

@iamnoah iamnoah added the enhancement New feature or request label Apr 28, 2021
jannfis pushed a commit that referenced this issue May 11, 2021
* feat: allow write-back to actual kustomization files #199

* fix: was not handling default path correctly

default is the source path

* fix: sort imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant