Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image updater removes transformers in kustomization.yaml #250

Closed
ghost opened this issue Sep 2, 2021 · 2 comments · Fixed by #274
Closed

Image updater removes transformers in kustomization.yaml #250

ghost opened this issue Sep 2, 2021 · 2 comments · Fixed by #274
Labels
bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Sep 2, 2021

Describe the bug
Overwriting parts of kustomization.yaml file wich not supposed to be touched. In this case is transformers. This issue is similar to #247

To Reproduce
Add to kustomization.yaml:

transformers:
- transformers/labels.yaml

The updater will remove it if the image is updated.

Expected behavior
Image updater doesn't remove transformers section in kustomization.yaml

Additional context
N/A

Version
0.10.1

Logs
N/A

@ghost ghost added the bug Something isn't working label Sep 2, 2021
@jannfis jannfis added this to the v0.11.0 milestone Sep 10, 2021
@jannfis
Copy link
Contributor

jannfis commented Sep 10, 2021

This is probably due to the fact that we import & use Kustomize v2.x - probably we should go for similar version that Argo CD uses (which is v4 as of Argo CD v2.1).

@thuandt
Copy link

thuandt commented Sep 13, 2021

It removed my KSOPS secret generator when I tried to write-back into kustomization.yaml file

jannfis pushed a commit that referenced this issue Oct 21, 2021
* fix: use kyaml to preserve kustomization

fixes #250
fixes #268
fixes #247

* chore: linter error

* fix: tests and linting

* go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants