Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hitting api requests limit in gcr #313

Closed
yosefy opened this issue Dec 8, 2021 · 1 comment · Fixed by #337
Closed

hitting api requests limit in gcr #313

yosefy opened this issue Dec 8, 2021 · 1 comment · Fixed by #337
Labels
bug Something isn't working
Milestone

Comments

@yosefy
Copy link

yosefy commented Dec 8, 2021

Describe the bug

we have about 600-700 tags in gcr registry for all the images

updater makes about 5000 api requests to gcr registry each time

running with default interval of 2 min we are hitting the limit of api requests

we are using tags like "prod" to deploy to prod "dev" for dev

Describe the solution you'd like
+
Expected behavior

only make one request per sha, also start from the end and if the needed tag is found , stop searching

may be some other solution?

Version
v0.10.3

Logs

time="2021-12-07T11:43:59Z" level=error msg="error fetching metadata for dev-collection/data-utils-server:0.46: Get "https://gcr.io/v2/ZZZ/YYY/blobs/sha256:97a804dd72026a88ca41869d3d998033ce8c1073af2c621616e15d059a4fb98a\": http: non-successful response (status=429 body="Quota Exceeded.")"

@yosefy yosefy added the bug Something isn't working label Dec 8, 2021
@jannfis jannfis added this to the v0.12.0 milestone Dec 16, 2021
@jannfis
Copy link
Contributor

jannfis commented Dec 16, 2021

There is actually an (unfortunately, not yet documented - see #318) tunable for setting the number of requests per second made to each registry endpoint by Image Updater.

Once the tags have been inspected, the results should be stored in the cache. I guess you hit the limit during cache warmup already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants