Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent update loop with git write-back #171

Merged
merged 1 commit into from Mar 25, 2021

Conversation

jannfis
Copy link
Contributor

@jannfis jannfis commented Mar 25, 2021

Signed-off-by: jannfis jann@mistrust.net

This will hopefully fix #170.

Prevent an update loop with Git write-back when not all of the images needed update by including also the non-updated images in the list of images to update.

Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #171 (6286514) into master (af590d3) will decrease coverage by 0.00%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   68.21%   68.20%   -0.01%     
==========================================
  Files          19       19              
  Lines        1337     1343       +6     
==========================================
+ Hits          912      916       +4     
- Misses        343      344       +1     
- Partials       82       83       +1     
Impacted Files Coverage Δ
pkg/argocd/update.go 71.60% <46.15%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af590d3...6286514. Read the comment docs.

@jannfis jannfis merged commit 21df300 into argoproj-labs:master Mar 25, 2021
jannfis added a commit that referenced this pull request Mar 25, 2021
Signed-off-by: jannfis <jann@mistrust.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update loop with git writeback in multi-image application
1 participant