Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a possible race condition in metadata retrieval #215

Merged
merged 2 commits into from Jun 15, 2021

Conversation

jannfis
Copy link
Contributor

@jannfis jannfis commented Jun 15, 2021

This fixes a possible race condition when fetching tag metadata from a registry.

Should fix #214, however I am not able to reproduce the original issue.

Signed-off-by: jannfis jann@mistrust.net

Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #215 (1f304d8) into master (45e6486) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   66.77%   66.77%           
=======================================
  Files          20       20           
  Lines        1574     1574           
=======================================
  Hits         1051     1051           
  Misses        424      424           
  Partials       99       99           
Impacted Files Coverage Δ
pkg/registry/registry.go 59.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e6486...1f304d8. Read the comment docs.

@jannfis jannfis merged commit 1d19e6a into argoproj-labs:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic: runtime error. Unsure if resources request/limits are causing it
1 participant