fix: modify SetKustomizeImage logic when use alias_name #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation, there was a problem that argocd-image-updater would create a new image when using newName of kustomize.
This is due to the fact that the current kustomize image information retrieved from the argucd API does not include the value of alias_name.
(
[<alias_name>=]<image_path>[:<version_constraint>]
)So, in this PR, even if the current image information doesn't contain alias_name, we can update the kustomize image information appropriately
ex. update kustomize images by argocd-image-updater
manifest
application.yaml
xxx/adservice/kustomization.yaml
xxx/adservice/deployment.yaml
result
before
after