Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct client ping endpoint #278

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

olemathias
Copy link
Contributor

This is to solve #276

Before:
Could not get tags from registry: unauthorized: authentication required

Ping in registry/client.go gets a 404 from https://ghcr.io/v2
While https://registry-1.docker.io/v2 get a 301 redirect to /v2/ (That I assume the client follows)

So just a extra / at the end of the "ping" url and it's working with GitHub Container Registry.

Tested DockerHub and GitHub Container Registry.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @olemathias !

@jannfis jannfis merged commit e42f982 into argoproj-labs:master Oct 19, 2021
@olemathias olemathias deleted the ping-endpoint branch October 19, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants