Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to solve #276
Before:
Could not get tags from registry: unauthorized: authentication required
Ping in
registry/client.go
gets a404
fromhttps://ghcr.io/v2
While
https://registry-1.docker.io/v2
get a301
redirect to/v2/
(That I assume the client follows)So just a extra / at the end of the "ping" url and it's working with GitHub Container Registry.
Tested DockerHub and GitHub Container Registry.