Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update and refactor Git client #283

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

jannfis
Copy link
Contributor

@jannfis jannfis commented Oct 26, 2021

This updates the Git client to the version from Argo CD v2.1.5

Should pull in a couple of enhancements, and also the possibility to use GitHub app authentication for repository interaction.

Signed-off-by: jannfis jann@mistrust.net

Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis merged commit a03f319 into argoproj-labs:master Oct 26, 2021
@timothyjlaurent
Copy link

I don't think this works. The GitHubAppCreds are never returned from this function https://github.com/jannfis/argocd-image-updater/blob/972500fc657f5980915f07317f963b4b091e4ff7/pkg/argocd/gitcreds.go#L49

@timothyjlaurent
Copy link

Likely related to #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants