Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename confusing update strategies #456

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

jaideepr97
Copy link
Collaborator

@jaideepr97 jaideepr97 commented Jul 12, 2022

This PR fixes #179.
It renames latest strategy to newest-build and name strategy to alphabetical. If either of the old names is detected, it prints a warning message in the controller logs informing the user that the strategies have been renamed, and that support for them will be removed in future releases. Currently the old names are still honored.
It also updates the documentation references for these update strategies.

Steps to test:

  1. Run Argo CD locally
  2. Create application with some image
  3. Generate argo-cd token
  4. annotate application with either newest-build or alphabetical depending on your use case/availability of test images
  5. Run image-updater
  6. app should be out of sync, and updated image should appear once app is successfully sync'd.
  7. Redeploy application and annotate with latest or name strategy
  8. Run image-updater
  9. Verify that logs contain warning message informing user to switch to new naming convention
  10. app should be out of sync, and updated image should appear once app is successfully sync'd.

@codecov-commenter
Copy link

Codecov Report

Merging #456 (8dcf374) into master (f12a5ab) will increase coverage by 0.10%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   65.60%   65.70%   +0.10%     
==========================================
  Files          21       21              
  Lines        2035     2041       +6     
==========================================
+ Hits         1335     1341       +6     
  Misses        571      571              
  Partials      129      129              
Impacted Files Coverage Δ
pkg/tag/tag.go 82.53% <ø> (ø)
pkg/image/version.go 40.69% <11.11%> (ø)
pkg/image/options.go 82.60% <100.00%> (+0.67%) ⬆️
pkg/registry/registry.go 54.95% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jaideepr97 jaideepr97 requested a review from jannfis July 12, 2022 20:21
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jannfis jannfis merged commit a0cf1e3 into argoproj-labs:master Jul 20, 2022
mcfearsome pushed a commit to mcfearsome/argocd-image-updater that referenced this pull request Jan 26, 2023
mcfearsome pushed a commit to mcfearsome/argocd-image-updater that referenced this pull request Oct 5, 2023
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename update strategies to remove confusion
3 participants