Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golangci-lint version in CI #457

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

jaideepr97
Copy link
Collaborator

@jaideepr97 jaideepr97 commented Jul 12, 2022

CI is failing on open PRs due to an older version of golangci-lint being used
According to golangci/golangci-lint#2374 older versions of golangci-lint are not compatible with go v1.18

Error message is:

Running [/home/runner/golangci-lint-1.32.2-linux-amd64/golangci-lint run --out-format=github-actions --timeout 5m] in [] ...
  level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package goarch: could not load export data: cannot import \"internal/goarch\" (unknown iexport format version 2), export data is newer version - update tool"
  level=warning msg="[runner] Can't run linter unused: buildir: failed to load package goarch: could not load export data: cannot import \"internal/goarch\" (unknown iexport format version 2), export data is newer version - update tool"
  level=error msg="Running error: buildir: failed to load package goarch: could not load export data: cannot import \"internal/goarch\" (unknown iexport format version 2), export data is newer version - update tool"

This PR updates the version to v1.46.2

@jaideepr97 jaideepr97 requested a review from jannfis July 12, 2022 20:46
@codecov-commenter
Copy link

Codecov Report

Merging #457 (ea843d1) into master (f12a5ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   65.60%   65.60%           
=======================================
  Files          21       21           
  Lines        2035     2035           
=======================================
  Hits         1335     1335           
  Misses        571      571           
  Partials      129      129           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jaideepr97
Copy link
Collaborator Author

/approve

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit ccb749f into argoproj-labs:master Jul 20, 2022
alexmt pushed a commit that referenced this pull request Dec 6, 2022
* update golangci-lint version

* update golangci-lint to v1.46.2
alexmt pushed a commit that referenced this pull request Dec 6, 2022
* update golangci-lint version

* update golangci-lint to v1.46.2
alexmt pushed a commit that referenced this pull request Dec 6, 2022
* update golangci-lint version

* update golangci-lint to v1.46.2
mcfearsome pushed a commit to mcfearsome/argocd-image-updater that referenced this pull request Jan 26, 2023
* update golangci-lint version

* update golangci-lint to v1.46.2
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
* update golangci-lint version

* update golangci-lint to v1.46.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants