Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added warning about existing tag in semver #471

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

kostis-codefresh
Copy link
Contributor

Signed-off-by: Kostis Kapelonis kostis@codefresh.io

When changing from latest to semver strategy, users must be careful and make sure that the existing
tag is already following semver

Otherwise trying to change from tag "rc1" to "1.0" or something similar doesn't work

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks and sorry for the late reaction

@jannfis jannfis merged commit 7068725 into argoproj-labs:master Nov 16, 2022
mcfearsome pushed a commit to mcfearsome/argocd-image-updater that referenced this pull request Jan 26, 2023
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants