Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ca-certificates to the docker image #497

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

aborilov
Copy link
Contributor

Fixes: #496

Signed-off-by: Pavel Aborilov aborilov@gmail.com

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2022

CLA assistant check
All committers have signed the CLA.

@aborilov aborilov changed the title add ca-certificates to the docker image fix: add ca-certificates to the docker image Nov 15, 2022
@jannfis
Copy link
Contributor

jannfis commented Nov 15, 2022

Thanks! Can you please rebase your PR to latest code - I have merged #492 which fixes the deprecation warnings in golangci-lint.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
@aborilov
Copy link
Contributor Author

Thanks! Can you please rebase your PR to latest code - I have merged #492 which fixes the deprecation warnings in golangci-lint.

done

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jannfis jannfis merged commit dba3046 into argoproj-labs:master Nov 18, 2022
alexmt pushed a commit that referenced this pull request Dec 6, 2022
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
mcfearsome pushed a commit to mcfearsome/argocd-image-updater that referenced this pull request Jan 26, 2023
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ca-certs in docker image
3 participants