Create directory automatically #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovick
force-pushed
the
create-directories-automatically
branch
from
4a7cbe0
to
854270f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
==========================================
- Coverage 56.16% 56.15% -0.01%
==========================================
Files 31 31
Lines 3105 3109 +4
==========================================
+ Hits 1744 1746 +2
- Misses 1222 1223 +1
- Partials 139 140 +1 ☔ View full report in Codecov by Sentry. |
|
@jannfis Any hints on how to resolve the CI failures? They do not appear to be related to my actual PR. Thanks for any guidance that you can provide. |
* When writing to a new file, create the directory for the file if it does not already exist * This is useful if writing `helmvalues` to a new directory that is solely used for updating the image version. The ArgoCD Application can add a second source and reference the file with the `ignoreMissingValueFiles` flag turned on as an additional values file * If the directory already exists, this command does nothing. Signed-off-by: Joshua Novick <joshua.novick@hunters.ai>
chengfang
force-pushed
the
create-directories-automatically
branch
from
3723a51
to
f91491a
Compare
chengfang
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
chengfang
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helmvaluesto a new directory that is solely used for updating the image version. The ArgoCD Application can add a second source and reference the file with theignoreMissingValueFilesflag turned on as an additional values fileThis will be most beneficial once #663 is also merged.