Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding tests for ask_pass cmd #749

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

zhaque44
Copy link
Contributor

Adding test coverage for the ask_pass cmd:

Description:

  • Mock Server: The mock server is used to simulate the gRPC service, ensuring we test the command's interaction with the gRPC client.
  • Environment Setup: Each test case sets up necessary env vars & cmd arguments.
  • Output Verification: The test case scenarios verify the cmd's output and error messages against expected values.

Signed-off-by: zhaque44 <haque.zubair@gmail.com>
Signed-off-by: zhaque44 <haque.zubair@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.91%. Comparing base (a309127) to head (6f8ebc0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   55.71%   55.91%   +0.19%     
==========================================
  Files          31       31              
  Lines        3060     3060              
==========================================
+ Hits         1705     1711       +6     
+ Misses       1218     1211       -7     
- Partials      137      138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Collaborator

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 3
🧪 Relevant tests Yes
🔒 Security concerns No
⚡ Key issues to review None

Copy link
Collaborator

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pasha-codefresh pasha-codefresh merged commit de47421 into argoproj-labs:master Jun 17, 2024
9 checks passed
@zhaque44 zhaque44 deleted the ask-pass-cmd-tests branch June 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants