Document specific workaround dedicated to ApplicationSet usage
#751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume VARA <guillaume.vara@gmail.com>
Amphaal
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
chengfang
reviewed
Jun 21, 2024
| By default, `ApplicationSet` prevents any manual modification of spawned `Application`. For example, if you try to update a child `Application` through the UI, the modification will be instantly reverted; this is an expected behavior. | ||
| Theses rejected manual modifications sadly include Image Updater's `spec.template.spec.source.helm.parameters` `Application` automatic patching, which will prevent `argocd-image-updater.argoproj.io/write-back-method: argocd` implicit behavior to function properly. | ||
|
|
||
| In this case, you will still receive `ImagesUpdated` events on your affected `Application`, but Image Updater will continously retry again, to no avail. |
There was a problem hiding this comment.
typo, change to "continuously"
| name: "{{ printf `%s-%s` `{{ .name }}` `{{ .branch }}` }}" | ||
| namespace: argocd | ||
| annotations: | ||
| # |
| - /spec/source/helm/parameters | ||
| ``` | ||
|
|
||
| This will prevent automatic revert behavior of `ApplicationSet` if any of the defined `jsonPointers` subjacent values are altered on children `Application`. |
There was a problem hiding this comment.
"subjacent values", do you mean something like subordinate values or child values?
|
|
||
| This will prevent automatic revert behavior of `ApplicationSet` if any of the defined `jsonPointers` subjacent values are altered on children `Application`. | ||
|
|
||
| Please mind there are also a few caveats to consider. (see https://argo-cd.readthedocs.io/en/stable/operator-manual/applicationset/Controlling-Resource-Modification/#limitations-of-ignoreapplicationdifferences) |
There was a problem hiding this comment.
Can you replace the raw link with a link with text display?
|
@Amphaal did you get a chance to check the recent review comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This missing piece of information might be related to a bunch of issues opened.