Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Catalog install.yaml not updated for latest release #186

Closed
aywrite opened this issue Feb 22, 2021 · 2 comments
Closed

Catalog install.yaml not updated for latest release #186

aywrite opened this issue Feb 22, 2021 · 2 comments
Labels
good first issue Good for newcomers
Milestone
v1.1

Comments

@aywrite
Copy link

aywrite commented Feb 22, 2021 •
edited
Loading

I noticed that #156/#157 was included in release 1.0.2 but the fix wasn't propagated to the install.yaml. Not sure if this is meant to be part of the CI process or just manually kept in sync with files in the catalog folder?

If it is manually kept in sync I'm happy to do a PR to fix this but wasn't sure of the normal release workflow.
@alexmt
Copy link
Collaborator

alexmt commented Mar 12, 2021

Hello @aywrite ! thank you for catching it!

The make generate is supposed to refresh all generated files. Looks like we forgot to do it. We should run make generate as part of CI and check that no files changed. If you have time to do it then PR would be very welcome!

@alexmt alexmt added this to the v1.1 milestone Mar 12, 2021
@ryota-sakamoto ryota-sakamoto added the good first issue Good for newcomers label Mar 15, 2021
@ryota-sakamoto
Copy link
Member

fixed by #214

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
3 participants
@alexmt @aywrite @ryota-sakamoto