Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd-operator release 0.8.0 #1020

Conversation

reginapizza
Copy link
Collaborator

What type of PR is this?

/kind chore

What does this PR do / why we need it:
Releases argocd-operator 0.8.0

  • also upgrades argocd version to 2.8.4

Copy link
Collaborator

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise

@@ -5,7 +5,7 @@ annotations:
operators.operatorframework.io.bundle.metadata.v1: metadata/
operators.operatorframework.io.bundle.package.v1: argocd-operator
operators.operatorframework.io.bundle.channels.v1: alpha
operators.operatorframework.io.metrics.builder: operator-sdk-v1.10.0+git
operators.operatorframework.io.metrics.builder: operator-sdk-v1.31.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change

description: Argo CD is a declarative, GitOps continuous delivery tool for Kubernetes.
operators.operatorframework.io/builder: operator-sdk-v1.10.0+git
operators.operatorframework.io/builder: operator-sdk-v1.31.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change.

@iam-veeramalla
Copy link
Collaborator

Please run make generate manifests bundle using operator-sdk version v.11.0 on your local.

Looks like your operator-sdk version is v1.31.0.

@reginapizza
Copy link
Collaborator Author

ah okay thanks, wasn't sure why that was happening- I think when I switched to my new laptop I just downloaded the latest operator-sdk without thinking about versioning with this. I'll update the PR!

@reginapizza reginapizza force-pushed the regina-argocd-operator-release-0.8 branch 2 times, most recently from d6d4649 to a6f1b98 Compare October 19, 2023 22:54
@reginapizza reginapizza changed the base branch from master to release-0.8 October 19, 2023 22:59
Copy link
Collaborator

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@reginapizza reginapizza force-pushed the regina-argocd-operator-release-0.8 branch from 944dee0 to 3be18a5 Compare October 31, 2023 19:07
Comment on lines 1 to 2
# Argo CD v2.8.4
FROM quay.io/argoproj/argocd@sha256:f02d31d4b115d79de3dc45ebeec3a3107b9178d980e69d9dc2b26019d43f3e09 as argocd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use v2.8.5 instead

@jaideepr97
Copy link
Collaborator

jaideepr97 commented Oct 31, 2023

@reginapizza I would recommend creating an alias for your git commit command so that the signoff is automatically added when you commit using that alias

@reginapizza reginapizza force-pushed the regina-argocd-operator-release-0.8 branch from 3be18a5 to 2a8fc36 Compare October 31, 2023 19:33
Copy link
Collaborator

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks @reginapizza

@reginapizza reginapizza merged commit f05a379 into argoproj-labs:release-0.8 Nov 2, 2023
5 checks passed
reginapizza added a commit to reginapizza/argocd-operator that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants