fix the logic for applicationset resources reconcilation when spec.applicationset.enabled is false #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicationset.enabled is false (argoproj-labs#1089) * fix the logic for applicationset resources reconciliation when spec.applicationset.enabled is false Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * delete repo server when repo.enabled is set to false Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Update status.Phase based on component enabled flag Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Added kuttl tests Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Added namespace creation step Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * delete services created for resources Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * delete server deployment when enabled flag set to false Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix e2e test Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix log message Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * revert kuttl test timeout Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Added test for reverse scenario Signed-off-by: Raghavi Shirur <rshirur@redhat.com> * Dir rename Signed-off-by: Raghavi Shirur <rshirur@redhat.com> * Added e2e test for ha mode Signed-off-by: Raghavi Shirur <rshirur@redhat.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Co-authored-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
ishitasequeira
force-pushed
the
cherry-pick-bugfix-enable-disable-components
branch
from
c238af6
to
13c98bd
Compare
anandf
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Cherry-pick #1089