Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky disable components e2e test #1214

Conversation

ishitasequeira
Copy link
Collaborator

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Currently the e2e test 1-034_validate_applicationset_reconcile_enabled_set_false seems to be working when argocd-controller is running locally, but failing when the test is executed against the cluster. The PR fixes the test flakiness.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

How to test changes / Special notes to the reviewer:

  • To execute locally:
    • Execute make install run in argocd-operator.
    • In a new tab, execute kubectl kuttl test ./tests/k8s --config ./tests/kuttl-tests.yaml --test 1-034_validate_applicationset_reconcile_enabled_set_false
  • To run against a cluster:
    • Deploy the operator in the cluster. Update your kube context to point to the cluster.
    • Execute the test using command kubectl kuttl test ./tests/k8s --config ./tests/kuttl-tests.yaml --test 1-034_validate_applicationset_reconcile_enabled_set_false

…t_false

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@svghadi svghadi merged commit b510aeb into argoproj-labs:release-0.9 Feb 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants