Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop argo-cd secret reseting admin password when updated using cli/dashboard #1257

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: stop argo-cd secret reseting admin password when updated using cli/dashboard #1257

merged 1 commit into from
Feb 26, 2024

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Feb 20, 2024 •
edited

What type of PR is this?
/kind bug

What does this PR do / why we need it:
This PR fixes the reset of Argo-cd admin password when updated using cli/dashboard. Argo-cd will reset the password when the data field for admin.password is nil.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes GITOPS-3581

How to test changes / Special notes to the reviewer:

To check it locally, running k8s cluster

  1. Run below command
make install run
  1. On different terminal run
kubectl port-forward service/example-argocd-server 8443:443
  1. Get login password and perform login
kubectl -n argocd get secret <secret-name> -o jsonpath="{.data.password}" | base64 -d; echo
argocd login --username admin --password <password>  127.0.0.1:8080
  1. Update password
$ argocd account update-password
*** Enter password of currently logged in user (admin):
*** Enter new password for user admin:
*** Confirm new password for user admin:
  1. Login using new password
    argocd login --username admin --password <NewPassword> 127.0.0.1:8080

@anandrkskd
fix: stop argo-cd secret reseting admin password when updated using c…
b1cd882 
…li/dashboard

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
@anandrkskd anandrkskd marked this pull request as ready for review February 20, 2024 12:53
svghadi
svghadi approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @anandrkskd

jaideepr97
jaideepr97 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svghadi svghadi merged commit af744a6 into argoproj-labs:master Feb 26, 2024
7 checks passed
@svghadi
Copy link
Collaborator

svghadi commented Feb 26, 2024

/cherry-pick release-0.9

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 26, 2024
@anandrkskd
fix: stop argo-cd secret reseting admin password when updated using c…
d8e0d56 
…li/dashboard (#1257)

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Feb 26, 2024
Merged
svghadi pushed a commit that referenced this pull request Feb 27, 2024
@gcp-cherry-pick-bot @anandrkskd
fix: stop argo-cd secret reseting admin password when updated using c…
8f65a5e 
…li/dashboard (#1257) (#1266)

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
Co-authored-by: Anand Kumar Singh <anandrkskd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaideepr97 jaideepr97 jaideepr97 approved these changes

@svghadi svghadi svghadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anandrkskd @svghadi @jaideepr97