fix: restrict server clusterrole list and watch permissions to only applications #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
jaideepr97
changed the title
jaideepr97
approved these changes
Nov 21, 2022
jaideepr97
pushed a commit
to jaideepr97/argocd-operator
that referenced
this pull request
Nov 21, 2022
jaideepr97
pushed a commit
to jaideepr97/argocd-operator
that referenced
this pull request
Nov 21, 2022
jaideepr97
added a commit
that referenced
this pull request
Nov 21, 2022
Signed-off-by: ishitasequeira <ishiseq29@gmail.com> (cherry picked from commit a6ceb7a) Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
iam-veeramalla
changed the title
iam-veeramalla
pushed a commit
that referenced
this pull request
Dec 14, 2022
* add list and watch only for applications for cluster role (#808) Signed-off-by: ishitasequeira <ishiseq29@gmail.com> (cherry picked from commit a6ceb7a) Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> * add sleep step Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ishitasequeira ishiseq29@gmail.com
What type of PR is this?
/kind chore
What does this PR do / why we need it:
add list and watch only for
applicationsresources and forargoproj.ioapigroups only for cluster roleHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: