Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in resource customizations documentation #821

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Fix error in resource customizations documentation #821

merged 1 commit into from
Dec 8, 2022

Conversation

reginapizza
Copy link
Collaborator

@reginapizza reginapizza commented Dec 6, 2022

What type of PR is this?
/kind bug
/kind documentation

What does this PR do / why we need it:
Fixes GITOPS-2451 to correct documentation about resource customizations

spec:
resourceIgnoreDifferences:
all:
jqPathExpressions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware that these fields have been changed to slices. That is good. Thanks. Please realistic examples instead of xyz and abc.

Signed-off-by: Regina Scott <rescott@redhat.com>
Copy link
Collaborator

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @reginapizza

@jaideepr97 jaideepr97 merged commit 2b4661b into argoproj-labs:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants