Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try to fix notification controller flaky test by adding sleep #823

Conversation

jaideepr97
Copy link
Collaborator

@jaideepr97 jaideepr97 commented Dec 8, 2022

add sleep to notification controller test

Signed-off-by: Jaideep Rao jaideep.r97@gmail.com

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind chore
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
@jaideepr97 jaideepr97 force-pushed the fix-notification-controller-flaky-test branch from 05e4fa3 to f81179a Compare December 9, 2022 15:14
Copy link
Collaborator

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@iam-veeramalla iam-veeramalla merged commit 9aff77f into argoproj-labs:master Dec 11, 2022
@jaideepr97 jaideepr97 mentioned this pull request Dec 13, 2022
2 tasks
@jaideepr97 jaideepr97 deleted the fix-notification-controller-flaky-test branch December 22, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants