-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow user instance monitoring #835
feat: Allow user instance monitoring #835
Conversation
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
…o allow-user-instance-monitoring
Great work @jaideepr97 💪 🚀 🚀 I've added a couple of comments, but I wouldn't consider any of those as blockers.
|
@drpaneas Thanks for taking a look :) I don't see any comments on here though, did they get saved? |
sorry I forgot to submit them. They should be visible now ;) |
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Please add documentation in the same PR. |
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for adding the documentation @jaideepr97
Approved.
What type of PR is this?
What does this PR do / why we need it:
This PR allows users to enable workload status monitoring for a given argo-cd instance. Users can enable monitoring for their instance by setting
.spec.monitoring.enabled
totrue
, which creates a PrometheusRule for alerts (with 7 opinionated alert rules within it - one for each workload). The rules are configured to fire when a workload has not had the required number of ready replicas for a certain duration of time out of the box. Users are free to delete or make changes to the alert rule and the operator would not overwrite the action.Have you updated the necessary documentation?
Not yet
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:
oc -n openshift-monitoring edit configmap cluster-monitoring-config
and settingdata.config.yaml.enableUserWorkload = true
(https://docs.openshift.com/container-platform/4.6/monitoring/enabling-monitoring-for-user-defined-projects.html?extIdCarryOver=true&sc_cid=701f2000001Css5AAC#enabling-monitoring-for-user-defined-projects_enabling-monitoring-for-user-defined-projects).spec.monitoring.enabled=true
in CR.spec.applicationSet.image=test-image
to create a situation where # desired replicas for appset controller != # ready replicasApplicationSetControllerNotReady
alert in this list (remove all pre-applied filters) with state initially set as "pending" which should change to "firing" after 10m