Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITOPS-2480: Added HOME env var to application controller #841

Conversation

ciiay
Copy link
Collaborator

@ciiay ciiay commented Jan 5, 2023

What type of PR is this?
/kind bug

What does this PR do / why we need it:
GITOPS-2480

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
Fixes GITOPS-2480

How to test changes / Special notes to the reviewer:

  1. Create an argocd instance in a namespace which doesn't have cluster admin permission.
  2. Run kubectl get pods -A -v=20 command in the argocd-application-controller terminal.
  3. Confirm that there's no .kube: permission denied error

@ciiay ciiay force-pushed the gitops-2480-set-application-controller-home branch from 1e38885 to c27e445 Compare January 5, 2023 18:59
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the gitops-2480-set-application-controller-home branch from f0210fe to 2747d40 Compare January 5, 2023 20:17
@wtam2018 wtam2018 merged commit 10f11b6 into argoproj-labs:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants