fix: operator overwrites server replicas when autoscale is enabled #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
wtam2018
reviewed
Feb 28, 2023
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
jaideepr97
changed the title
wtam2018
approved these changes
Mar 1, 2023
ciiay
pushed a commit
to ciiay/argocd-operator
that referenced
this pull request
Mar 20, 2023
…rgoproj-labs#860) Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Currently, the operator does not respect server autoscale configuration expressed in CR. The HPA controller tries to edit replica setting in server deployment, but operator overwrites it. This PR changes the logic to only reconcile on replica drift if autoscale is disabled.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:
.spec.server.autoscale.enabledto true.spec.server.autoscale.hpa