Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a environment variable page #864

Merged

Conversation

ciiay
Copy link
Collaborator

@ciiay ciiay commented Feb 22, 2023

What type of PR is this?
/kind documentation

What does this PR do / why we need it:
There's no environment variable list in the existing documentation.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
GITOPS-2023

Screenshot
Screenshot 2023-03-20 at 3 00 16 PM

@ciiay ciiay force-pushed the gitops-2023-add-doc-for-env-var-list branch from 2c76693 to bf849b5 Compare February 22, 2023 14:30
@ciiay
Copy link
Collaborator Author

ciiay commented Mar 10, 2023

Hi @iam-veeramalla , please review this RP, thanks.

@iam-veeramalla
Copy link
Collaborator

iam-veeramalla commented Mar 20, 2023

Can you please add details about the environmental variables support in the Argo CD CR for each component.

For Example:

kind: ArgoCD
...
...
spec:
  controller:
     env:
       - name: foo
          value: bar

@ciiay
Copy link
Collaborator Author

ciiay commented Mar 20, 2023

Hi @iam-veeramalla , I updated PR as per comment. I still have a question, about the custom environment variables, there’s already a page that has the information. Aren't these env variables part of ArgoCD, not part of argocd-operator?
https://github.com/argoproj-labs/argocd-operator/blob/master/docs/reference/argocd.md

@ciiay ciiay force-pushed the gitops-2023-add-doc-for-env-var-list branch from e0a3c21 to 54d3b53 Compare March 20, 2023 19:03
@iam-veeramalla
Copy link
Collaborator

Hi @iam-veeramalla , I updated PR as per comment. I still have a question, about the custom environment variables, there’s already a page that has the information. Aren't these env variables part of ArgoCD, not part of argocd-operator? https://github.com/argoproj-labs/argocd-operator/blob/master/docs/reference/argocd.md

@ciiay yes there is a page already, do you want to just the page to this new page ?

@ciiay ciiay force-pushed the gitops-2023-add-doc-for-env-var-list branch 2 times, most recently from 1474070 to ecf8046 Compare March 21, 2023 18:58
@ciiay
Copy link
Collaborator Author

ciiay commented Mar 21, 2023

Hi @iam-veeramalla , I updated PR as per comment. I still have a question, about the custom environment variables, there’s already a page that has the information. Aren't these env variables part of ArgoCD, not part of argocd-operator? https://github.com/argoproj-labs/argocd-operator/blob/master/docs/reference/argocd.md

@ciiay yes there is a page already, do you want to just the page to this new page ?

As discussed I kept the information on this environment variable page as a good summary of environment variables available on argocd-operator. Thanks for the confirmation.

@ciiay ciiay force-pushed the gitops-2023-add-doc-for-env-var-list branch 2 times, most recently from 9b8dc6b to 3dff4af Compare March 21, 2023 19:52
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the gitops-2023-add-doc-for-env-var-list branch from fc62d07 to 51d28b2 Compare March 21, 2023 20:05
Copy link
Collaborator

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @ciiay

@iam-veeramalla iam-veeramalla merged commit 78520b8 into argoproj-labs:master Mar 22, 2023
ThomVivet pushed a commit to ThomVivet/argocd-operator that referenced this pull request Apr 14, 2023
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: ThomVivet <thomas.vivet@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants