-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a environment variable page #864
Added a environment variable page #864
Conversation
2c76693
to
bf849b5
Compare
Hi @iam-veeramalla , please review this RP, thanks. |
Can you please add details about the environmental variables support in the Argo CD CR for each component. For Example:
|
Hi @iam-veeramalla , I updated PR as per comment. I still have a question, about the custom environment variables, there’s already a page that has the information. Aren't these env variables part of |
e0a3c21
to
54d3b53
Compare
@ciiay yes there is a page already, do you want to just the page to this new page ? |
1474070
to
ecf8046
Compare
As discussed I kept the information on this environment variable page as a good summary of environment variables available on argocd-operator. Thanks for the confirmation. |
9b8dc6b
to
3dff4af
Compare
Signed-off-by: Yi Cai <yicai@redhat.com>
fc62d07
to
51d28b2
Compare
…ator into gitops-2023-add-doc-for-env-var-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @ciiay
Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: ThomVivet <thomas.vivet@free.fr>
What type of PR is this?
/kind documentation
What does this PR do / why we need it:
There's no environment variable list in the existing documentation.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
GITOPS-2023
Screenshot