fix: Reconcile Dex client secret when .spec.dex is set #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <jann@mistrust.net>
iam-veeramalla
approved these changes
Mar 20, 2023
ciiay
pushed a commit
to ciiay/argocd-operator
that referenced
this pull request
Mar 20, 2023
…#877) Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Yi Cai <yicai@redhat.com>
This was referenced Mar 24, 2023
iam-veeramalla
pushed a commit
that referenced
this pull request
Mar 27, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
#872 moved the actual Dex client secret to the
argocd-secretand references it from the Dex configuration.However, the change only considers
.spec.sso.dexto figure out whether the client secret should be written. There is the (old) way of having Dex configuration in.spec.dex, and while being deprecated, is still used in the wild.This change considers both, existence of
.spec.dexand.spec.sso.dexas the trigger for reconciling the client secret into theargocd-secret.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-2761
How to test changes / Special notes to the reviewer: