Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add timeline to remove deprecated resourceCustomizations #900

Merged
merged 2 commits into from May 8, 2023

Conversation

svghadi
Copy link
Collaborator

@svghadi svghadi commented May 8, 2023

What type of PR is this?
/kind chore

What does this PR do / why we need it:
This PR adds removal timeline for deprecated resourceCustomizations. The resourceCustomizations was deprecated in v0.5.0 and is planned to be removed in v0.8.0.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

How to test changes / Special notes to the reviewer:

  1. Run the operator locally using make install run
  2. Create a argocd instance using deprecated resourceCustomizations field

    eg: https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#resource-customizations-example

  3. Execute kubectl get events | grep ResourceCustomizations
  4. Observe that deprecation event was emitted
    9m19s       Warning   DeprecationNotice         argocd/example-argocd                               ResourceCustomizations is deprecated, and support will be removed in Argo CD Operator v0.8.0/OpenShift GitOps v1.10.0. Please use the new formats `ResourceHealthChecks`, `ResourceIgnoreDifferences`, and `ResourceActions`.
    

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi svghadi changed the title chore: Add removal timeline for deprecated resourceCustomizations chore: Add timeline to remove deprecated resourceCustomizations May 8, 2023
docs/reference/argocd.md Outdated Show resolved Hide resolved
docs/reference/argocd.md Outdated Show resolved Hide resolved
…essage

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Copy link
Collaborator

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @svghadi

@jaideepr97 jaideepr97 merged commit 9fefa31 into argoproj-labs:master May 8, 2023
7 checks passed
@svghadi svghadi deleted the rc-depr-timeline branch May 11, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants