-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add e2e-test to verify hpa handling behavior #904
Merged
iam-veeramalla
merged 10 commits into
argoproj-labs:master
from
jaideepr97:fix-hpa-recon
Jun 13, 2023
Merged
feat: add e2e-test to verify hpa handling behavior #904
iam-veeramalla
merged 10 commits into
argoproj-labs:master
from
jaideepr97:fix-hpa-recon
Jun 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
iam-veeramalla
approved these changes
Jun 13, 2023
ciiay
pushed a commit
to ciiay/argocd-operator
that referenced
this pull request
Jun 16, 2023
* upgrade golangci-lint Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> * add kuttl test to verify hpa handling behavior Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> * fix typo in assert file name Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> --------- Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
pushed a commit
to ciiay/argocd-operator
that referenced
this pull request
Jun 17, 2023
* upgrade golangci-lint Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> * add kuttl test to verify hpa handling behavior Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> * fix typo in assert file name Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> --------- Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
pushed a commit
to ciiay/argocd-operator
that referenced
this pull request
Jun 20, 2023
* upgrade golangci-lint Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> * add kuttl test to verify hpa handling behavior Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> * fix typo in assert file name Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> --------- Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Adds a kuttl test to verify that
spec.server.autoscale.hpa
the changes are propogated to hpa object and applied to the clusterHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: