Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e-test to verify hpa handling behavior #904

Merged
merged 10 commits into from
Jun 13, 2023

Conversation

jaideepr97
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind chore
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Adds a kuttl test to verify that

  • when server autoscale is enabled, operator does not try to overwrite changes made to the server deployment replica count by the hpa
  • when hpa parameters are adjusted in spec.server.autoscale.hpa the changes are propogated to hpa object and applied to the cluster

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

@iam-veeramalla iam-veeramalla merged commit dbd4a30 into argoproj-labs:master Jun 13, 2023
7 checks passed
ciiay pushed a commit to ciiay/argocd-operator that referenced this pull request Jun 16, 2023
* upgrade golangci-lint

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

* add kuttl test to verify hpa handling behavior

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

* fix typo in assert file name

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

---------

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay pushed a commit to ciiay/argocd-operator that referenced this pull request Jun 17, 2023
* upgrade golangci-lint

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

* add kuttl test to verify hpa handling behavior

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

* fix typo in assert file name

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

---------

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay pushed a commit to ciiay/argocd-operator that referenced this pull request Jun 20, 2023
* upgrade golangci-lint

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

* add kuttl test to verify hpa handling behavior

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

* fix typo in assert file name

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

---------

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
@jaideepr97 jaideepr97 deleted the fix-hpa-recon branch February 14, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants