fix: ExecTimeout should set env variable as time.duration #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tr3mor <storozhenkopf@gmail.com>
Signed-off-by: tr3mor <storozhenkopf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
ExecTimeout option sets ARGOCD_EXEC_TIMEOUT env variable as an integer value. According to docs: https://argo-cd.readthedocs.io/en/stable/operator-manual/high_availability it should be in Go time duration string format.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #875
How to test changes / Special notes to the reviewer: