fix: replace kube-rbac-proxy image tag v0.8.0 with its digest equivalent (#510) #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This PR fixes installation in environments that require images to be mirrored by digest rather than tag, such as openshift in a "restricted" network install.
Note that this PR includes modifying older CSV versions. I'm not sure that's kosher. If not, please free to leave out that part, or kick it back to me for fixing.
Have you updated the necessary documentation?
N/A
Which issue(s) this PR fixes:
Fixes #510
How to test changes / Special notes to the reviewer:
Issue #510 includes a description of how to test that the actual problem is fixed.
That said, it's a lot of work. It should also be possible to upgrade an existing installation, and just look at the output of
If the pod is running and has a kube-rbac-proxy image specified by digest instead of tag, you know it's working.