Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace kube-rbac-proxy image tag v0.8.0 with its digest equivalent (#510) #919

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

mortya
Copy link
Contributor

@mortya mortya commented May 31, 2023

What type of PR is this?

/kind bug

What does this PR do / why we need it:

This PR fixes installation in environments that require images to be mirrored by digest rather than tag, such as openshift in a "restricted" network install.

Note that this PR includes modifying older CSV versions. I'm not sure that's kosher. If not, please free to leave out that part, or kick it back to me for fixing.

Have you updated the necessary documentation?

N/A

Which issue(s) this PR fixes:

Fixes #510

How to test changes / Special notes to the reviewer:

Issue #510 includes a description of how to test that the actual problem is fixed.

That said, it's a lot of work. It should also be possible to upgrade an existing installation, and just look at the output of

ns=argocd; # or whatever
kubectl -n $ns get po -l control-plane=controller-manager;
kubectl -n $ns get po -l control-plane=controller-manager -o json | jq '.items[].spec.containers[0].image' -r

If the pod is running and has a kube-rbac-proxy image specified by digest instead of tag, you know it's working.

@jaideepr97
Copy link
Collaborator

Hi @mortya thanks for your PR!

I think it would be best to leave this change out of the released version bundles
would you mind restricting this to master and the 0.7.0 bundle?

@mortya
Copy link
Contributor Author

mortya commented Jun 2, 2023

Hi, @jaideepr97 ! I do not at all mind modifying the PR to only apply to new cluster service versions. Done. Not sure what the fashion is here for correcting PRs; did it as an amend and a force push rather than a new commit. Hope that's OK!

Copy link
Collaborator

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @mortya !
LGTM

@jaideepr97 jaideepr97 merged commit 15812e7 into argoproj-labs:master Jun 6, 2023
7 checks passed
ciiay pushed a commit to ciiay/argocd-operator that referenced this pull request Jun 8, 2023
…ent (argoproj-labs#510) (argoproj-labs#919)

Signed-off-by: Morty Abzug <morty@frakir.org>
Co-authored-by: Morty Abzug <morty@frakir.org>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay pushed a commit to ciiay/argocd-operator that referenced this pull request Jun 8, 2023
…ent (argoproj-labs#510) (argoproj-labs#919)

Signed-off-by: Morty Abzug <morty@frakir.org>
Co-authored-by: Morty Abzug <morty@frakir.org>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay pushed a commit to ciiay/argocd-operator that referenced this pull request Jun 8, 2023
…ent (argoproj-labs#510) (argoproj-labs#919)

Signed-off-by: Morty Abzug <morty@frakir.org>
Co-authored-by: Morty Abzug <morty@frakir.org>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay pushed a commit to ciiay/argocd-operator that referenced this pull request Jun 20, 2023
…ent (argoproj-labs#510) (argoproj-labs#919)

Signed-off-by: Morty Abzug <morty@frakir.org>
Co-authored-by: Morty Abzug <morty@frakir.org>
Signed-off-by: Yi Cai <yicai@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-rbac-proxy Image with tag hinders disconnected deployments
2 participants