fix: add reference doc for Extra Config (#858) #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morty Abzug <morty@frakir.org>
|
hi @mortya This is already documented here: https://github.com/argoproj-labs/argocd-operator/blob/master/docs/usage/extra-config.md and is accessible through the side-nav bar on readthedocs |
|
Thanks, @jaideepr97. I did eventually find that other doc. But it wasn't in the reference for the actual argocd CRD, which is where I initially looked. Normally that sort of type reference lists all features of the type at a basic level, even if they are also (better) documented elsewhere. So it should document extraConfig. |
ciiay
pushed a commit
to ciiay/argocd-operator
that referenced
this pull request
Jun 8, 2023
…rgoproj-labs#921) Signed-off-by: Morty Abzug <morty@frakir.org> Co-authored-by: Morty Abzug <morty@frakir.org> Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
pushed a commit
to ciiay/argocd-operator
that referenced
this pull request
Jun 8, 2023
…rgoproj-labs#921) Signed-off-by: Morty Abzug <morty@frakir.org> Co-authored-by: Morty Abzug <morty@frakir.org> Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
pushed a commit
to ciiay/argocd-operator
that referenced
this pull request
Jun 20, 2023
…rgoproj-labs#921) Signed-off-by: Morty Abzug <morty@frakir.org> Co-authored-by: Morty Abzug <morty@frakir.org> Signed-off-by: Yi Cai <yicai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What does this PR do / why we need it:
The reference for argocd does not include extraConfig. I spent a while looking for something like that. Issue #858 implies I'm not the only one.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #858