Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove avp prefix from aws env vars #134

Merged
merged 2 commits into from
Jun 9, 2021
Merged

fix: remove avp prefix from aws env vars #134

merged 2 commits into from
Jun 9, 2021

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Jun 8, 2021

Description

For AWS secrets manager, we have to use the aws defined env vars without the AVP prefix.

Fixes: #133 #131

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Docs have been added / updated

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

Also added k8s as a valid auth type to the supported parameters table

@werne2j werne2j self-assigned this Jun 8, 2021
@werne2j werne2j requested a review from jkayani as a code owner June 8, 2021 17:11
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #134 (568d67b) into main (60292a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   57.88%   57.88%           
=======================================
  Files          16       16           
  Lines         539      539           
=======================================
  Hits          312      312           
  Misses        187      187           
  Partials       40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60292a8...568d67b. Read the comment docs.

@werne2j werne2j merged commit c2e68f1 into main Jun 9, 2021
@werne2j werne2j deleted the updateAuthDocs branch June 9, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants