-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support 1Password Connect as a backend #303
feat: Support 1Password Connect as a backend #303
Conversation
Codecov Report
@@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 76.52% 76.51% -0.01%
==========================================
Files 21 22 +1
Lines 920 941 +21
==========================================
+ Hits 704 720 +16
- Misses 134 137 +3
- Partials 82 84 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will let @jkayani take a look before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code, tests and docs look great! Thanks for the work @lucasmarshall. I'd like to resolve at least the dependency question since the OP SDK should be marked as a direct dependency (thinking about build issues if dependencies aren't categorized correctly). The other things aren't big deals but I leave it to you to make any changes if you see fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
go.mod
Outdated
@@ -52,6 +52,8 @@ require ( | |||
sigs.k8s.io/yaml v1.3.0 | |||
) | |||
|
|||
require github.com/1Password/connect-sdk-go v1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one small thing. I would like this to be up in the above require block. Seems a little odd to have another require block with just one package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. go mod tidy
put this here. Not sure why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lucasmarshall!
Description
Add support for 1Password Connect servers as a backend
Fixes: #235
Checklist
Please make sure that your PR fulfills the following requirements:
Type of Change