Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to use inline Helm values in ArgoCD manifests #309

Merged
merged 2 commits into from
Mar 3, 2022
Merged

docs: how to use inline Helm values in ArgoCD manifests #309

merged 2 commits into from
Mar 3, 2022

Conversation

jstaf
Copy link
Contributor

@jstaf jstaf commented Mar 2, 2022

Description

This adds documentation on how to use argocd-vault-plugin with Helm values inline in the ArgoCD application manifest (similar to the --values-literal-file option or declarative setup here https://github.com/argoproj/argo-cd/blob/cd497c4eec84a47040816a0b04361005c3ce0ee8/docs/operator-manual/application.yaml#L39-L52).

I also changed the example argocd-cm.yml manifest to include $ARGOCD_APP_NAME to match the examples from the docs.

Fixes: #304 and also #266 (but only for the CLI workflow).

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @jstaf!

@jkayani jkayani changed the title Document how to use inline Helm values in ArgoCD manifests docs: how to use inline Helm values in ArgoCD manifests Mar 3, 2022
Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't realize process substitution could be of use here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants