Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix modifiers link #313

Merged
merged 2 commits into from
Mar 11, 2022
Merged

docs: fix modifiers link #313

merged 2 commits into from
Mar 11, 2022

Conversation

fty4
Copy link
Contributor

@fty4 fty4 commented Mar 9, 2022

Description

  • modifiers: link starting with a capital letter only works on GitHub Markdown - not within readthedocs.io
  • backends: link with single dot will not forward to page on readthedocs.io

(tested with Chrome, Windows, Firefox, Ubuntu)

This PR change will only fix two hyperlink.

Fixes:

  • fix hyperlink (anker) on same page to Modifiers - using lower case
  • fix hyperlink to backends page - using two dots as already in use

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2022

CLA assistant check
All committers have signed the CLA.

@werne2j
Copy link
Member

werne2j commented Mar 11, 2022

Thanks @fty4! If you could resolve the conflicts, we can continue with the review process.

1 similar comment
@werne2j
Copy link
Member

werne2j commented Mar 11, 2022

Thanks @fty4! If you could resolve the conflicts, we can continue with the review process.

starting with a capital letter only works on GitHub not within readthedocs.io
link does not work within readthedocs.io
@fty4
Copy link
Contributor Author

fty4 commented Mar 11, 2022

@werne2j solved the merge conflict

Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fty4!

@werne2j werne2j merged commit a0bcc31 into argoproj-labs:main Mar 11, 2022
@fty4 fty4 deleted the fty4/docs-link branch March 11, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants