Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Add examples for aws secrets manager #319

Conversation

ricardojdsilva87
Copy link
Contributor

Description

Addition of some examples of usage for cross account stored secrets on AWS Secrets Manager.
The ARN of the secret can be used in this case. Permissions on IAM roles and KMS keys are needed to configure the cross account access, links added

Fixes:
Existent examples were vault examples:
#316

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@werne2j werne2j merged commit 2829a41 into argoproj-labs:main Mar 14, 2022
@ricardojdsilva87 ricardojdsilva87 deleted the docs_add_aws_secrets_manager_examples branch March 15, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants