Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure manifests into Components for composability #372

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Restructure manifests into Components for composability #372

wants to merge 3 commits into from

Commits on Aug 24, 2022

  1. feat[manifests]: Allow BYO argocd 

    Restructuring the manifests to allow consumers of AVP to bring their own argocd
base by using the kustomize components manifests under `manifests/components`.

This allows consumers to integrate more easily with other CMPs or alternate
versions of argo that the AVP maintainers haven't patched the manifests to
include.

NB this requires use of kustomize > v3.7.0 when Components were introduced. For
more information about components see the docs:
https://kubectl.docs.kubernetes.io/guides/config_management/components/
    @jskrzypek
    jskrzypek committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e626fa9 View commit details
    Browse the repository at this point in the history

  2. feat[manifests]: Restore root manifest 

    PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default
manifest, which was available through a reference to
https://github.com/argoproj-labs/argocd-vault-plugin//manifests

To get the same app, consumers would need to change any exsting references to
https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap

This commit introduces a simple proxy manifest that makes that change backwards
compatible, meaning that now older references to
https://github.com/argoproj-labs/argocd-vault-plugin//manifests
will still resolve to the same app state as
https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap
rather than just breaking.
    @jskrzypek
    jskrzypek committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    41fea60 View commit details
    Browse the repository at this point in the history

  3. docs: Add instructions for plugin components 

    Describe how to use the plugin-only component manifests for use with alternate
versions of ArgoCD (e.g. HA, newer releases, etc.)
    @jskrzypek
    jskrzypek committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    fdea29b View commit details
    Browse the repository at this point in the history