Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): support for version stage #486

Merged
merged 2 commits into from
Apr 1, 2023
Merged

fix(aws): support for version stage #486

merged 2 commits into from
Apr 1, 2023

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Apr 1, 2023

Description

Add support for AWSCURRENT and AWSPREVIOUS

Fixes: #453

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@werne2j werne2j self-assigned this Apr 1, 2023
@werne2j werne2j requested a review from jkayani as a code owner April 1, 2023 16:36
@werne2j werne2j changed the title Awsversion fix(aws): support for version stage Apr 1, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #486 (663040e) into main (98e3987) will decrease coverage by 0.15%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   77.70%   77.55%   -0.15%     
==========================================
  Files          24       24              
  Lines        1610     1613       +3     
==========================================
  Hits         1251     1251              
- Misses        268      269       +1     
- Partials       91       93       +2     
Impacted Files Coverage Δ
pkg/backends/awssecretsmanager.go 65.85% <40.00%> (-5.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@werne2j werne2j merged commit 7271864 into main Apr 1, 2023
@werne2j werne2j deleted the awsversion branch April 1, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants