Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mount path to verbose logging for approle #489

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Apr 3, 2023

Description

Add mount path to verbose logging for approle

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe) - improve logging

Other information

@werne2j werne2j requested a review from jkayani as a code owner April 3, 2023 13:44
@werne2j werne2j self-assigned this Apr 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #489 (c3789c8) into main (ddbd42b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   75.31%   75.31%           
=======================================
  Files          25       25           
  Lines        1689     1689           
=======================================
  Hits         1272     1272           
  Misses        323      323           
  Partials       94       94           
Impacted Files Coverage Δ
pkg/auth/vault/approle.go 68.96% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@werne2j werne2j merged commit b587367 into main Apr 3, 2023
@werne2j werne2j deleted the approleLogging branch April 3, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants